threefoldtecharchive / 0-core

Multi Node OS which requires no install.
Apache License 2.0
3 stars 2 forks source link

return container mapped to its id in containermanager get #143

Closed LeeSmet closed 5 years ago

LeeSmet commented 5 years ago

so the id is also accessible in case a container is looked up using its name

codecov-io commented 5 years ago

Codecov Report

Merging #143 into 1.5.0-rc1 will decrease coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           1.5.0-rc1     #143      +/-   ##
=============================================
- Coverage      25.12%   25.09%   -0.04%     
=============================================
  Files             59       59              
  Lines           5768     5775       +7     
=============================================
  Hits            1449     1449              
- Misses          4196     4203       +7     
  Partials         123      123
Impacted Files Coverage Δ
apps/core0/subsys/containers/manager.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cd9bc5...cb31dfb. Read the comment docs.

LeeSmet commented 5 years ago

@zaibon yeah I just did it like this to bring it in line with the way it is done in other methods, I'll add it to the response itself