search

threefoldtecharchive / 0-core

Multi Node OS which requires no install.
Apache License 2.0
3 stars 2 forks source link

allow name/typeStr duplicates in dmi decoding #159

Closed GlenDC closed 5 years ago

GlenDC commented 5 years ago

When we have sections with the same TypeStr, as is for example the case for MemoryDevice (where we have one such section per actual RAM device), it would only output the one last found, and thus ignoring all but one. A similar bug could happen in case a section has multiple sub sections with the same name (not sure this could happen, but at this point I prefer to be safe than sorry).

Prior to all my bug fixing in the 0-core DMI decoding plugin we used the name (now called Title of SubSection) as the mapping to a Section, which would have given the same issue. So this bug was already present, be it in a different package.

GlenDC commented 5 years ago

This PR is done and ready for review @zaibon.