threefoldtecharchive / 0-core

Multi Node OS which requires no install.
Apache License 2.0
3 stars 2 forks source link

Rewrite nft parsing using json #83

Closed muhamadazmy closed 6 years ago

muhamadazmy commented 6 years ago

This is done this way to avoid some inconsistency of the human readable nft output that sometimes causes parsing issues.

This might have cause some port forward deletion to fail because zos can't find the rule handle anymore.

Probably fixes #77

The new parser has been covered by unittests, but we need to test actual nodes that were affected by this bug.

codecov-io commented 6 years ago

Codecov Report

Merging #83 into development will increase coverage by 0.71%. The diff coverage is 60.37%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #83      +/-   ##
===============================================
+ Coverage        25.34%   26.06%   +0.71%     
===============================================
  Files               54       54              
  Lines             5157     5337     +180     
===============================================
+ Hits              1307     1391      +84     
- Misses            3741     3812      +71     
- Partials           109      134      +25
Impacted Files Coverage Δ
base/nft/nft.go 33.33% <0%> (-21.51%) :arrow_down:
apps/core0/subsys/containers/network.go 0% <0%> (ø) :arrow_up:
apps/core0/helper/socat/socat.go 21.17% <0%> (-0.26%) :arrow_down:
base/nft/parser.go 69.18% <71.11%> (-12.63%) :arrow_down:
apps/core0/subsys/containers/flist.go 39.44% <0%> (+6.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5eb2dae...4e79800. Read the comment docs.