search

threefoldtecharchive / 0-robot

Distributed live cycle management system
Apache License 2.0
0 stars 0 forks source link

FR: `_send_eco_webhooks` also sends the robot id #44

Closed chrisvdg closed 6 years ago

chrisvdg commented 6 years ago

In the robot portal ECO's I can't see which robot sent the eco, Would be nice to have the id of the robot so the eco can be mapped to a robot.

zaibon commented 6 years ago

@chrisvdg what do you call robot id ?

chrisvdg commented 6 years ago

Hmm I think that would be the node_sal.name that you pass as id to the robot portal

zaibon commented 6 years ago

the robot has no knowledge of that. The services that register to the portal can, but the robot itself not

chrisvdg commented 6 years ago

Very inconvenient then to have eco's but no idea who sent them, any ideas to get around this?

chrisvdg commented 6 years ago

I do get service uuid but then I would need to check all robots to see if they have that service

zaibon commented 6 years ago

yeah well, not much I can do from the robot unfortunately. I'll close. feel free to re-open if you find another solution that could be implemented in the robot