threefoldtecharchive / jumpscaleX_archived

Apache License 2.0
1 stars 6 forks source link

make sure all startup cmd usage is fixed with the new interface #727

Closed rkhamis closed 5 years ago

ranatrk commented 5 years ago

Fix: change cmd in startup_cmds() to cmd_start https://github.com/threefoldtech/jumpscaleX/commit/d67141f0a751200f0847a3862ef3c4f4839fb026

ranatrk commented 5 years ago

branch: _[jumpscaledevelopment]

siddiquagig commented 5 years ago

Verified and tested with a builder

3BOTDEVEL:3bot:jumpscaleX: git log -1
commit ce2806ac1b2b07cc96021c43f1e1b5ad30d9646a (HEAD -> development_jumpscale, origin/development_jumpscale)
Author: Reem Khamis <khamisr@codescalers.com>
Date:   Thu Jul 18 10:51:15 2019 +0200

    Move builders under builders
siddiquagig commented 5 years ago

It is not working for servers with ports :

rana

ranatrk commented 5 years ago

Fix for servers with ports : https://github.com/threefoldtech/jumpscaleX/commit/25ba825f909229bf359febb1e42b5259df531f42

siddiquagig commented 5 years ago

Working now for redis.start() but not for nginx.start()

JSX> j.builders.db.redis.start()

redis1

nginx.start() :

nginx1

ranatrk commented 5 years ago

Fix : use exec -a cmd_name when starting to use the name rather than the cmd itself when checking if running or getting pid. https://github.com/threefoldtech/jumpscaleX/commit/7369315ecea52fe29ed9c7ada0d9fc7306702ebf

siddiquagig commented 5 years ago

Verified for nginx also, its working now:

nginx2

commit 011a7bc4f589a42f6f969abd1a9fb4ef5fa7dfa5 (HEAD -> development_jumpscale, origin/development_jumpscale)
Author: Reem Khamis <khamisr@codescalers.com>
Date:   Thu Jul 25 12:45:34 2019 +0200

    Add resty-auto-ssl dependency to luabuilder