jumpscale installer needs to have the branch parameterized

rkhamis commented 5 years ago

This is to enable autotesting on multiple branches as well as prevent merge issues with branch names in the installer.

It should default currently to development_jumpscale until we merge back to development

waleedhammam commented 5 years ago

We have two scenarios now Case 1

install normally without passing a branch. /tmp/jsx install That will download InstallTools.py and installs from the default branch which is hardcoded in the jsx.py script

Case 2

Passing the branch through installation /tmp/jsx install -b hamada That will download InstallTools.py and installs from the hamada branch.
Commit: https://github.com/threefoldtech/jumpscaleX/commit/487a8044cf6ab3bc8b8ce065dbeab20023e667b0 ; branch: development_jumpscale

Dinaamagdy commented 5 years ago

blocked on https://github.com/threefoldtech/jumpscaleX/issues/738

Dinaamagdy commented 5 years ago

when I install from branch exist in jumpscale ,it return the following error as it can't checkout from this brnach in digital me

+ cd /sandbox/code/github/threefoldtech/digitalmeX
+ git checkout development_builders -f
error: pathspec 'development_builders' did not match any file(s) known to git.

EXCEPTION

        jsx                                                          : 587 : cli()
        /root/.local/lib/python3.6/site-packages/click/core.py       : 764 : return self.main(*args, **kwargs)
        /root/.local/lib/python3.6/site-packages/click/core.py       : 717 : rv = self.invoke(ctx)
        /root/.local/lib/python3.6/site-packages/click/core.py       : 1137: return _process_result(sub_ctx.command.invoke(sub_ctx))
        /root/.local/lib/python3.6/site-packages/click/core.py       : 956 : return ctx.invoke(self.callback, **ctx.params)
        /root/.local/lib/python3.6/site-packages/click/core.py       : 555 : return callback(*args, **kwargs)
        jsx                                                          : 316 : installer.install(sandboxed=False, force=force, gitpull=pull)
        /tmp/InstallTools.py                                         : 2948: self.repos_get(pull=gitpull)
        /tmp/InstallTools.py                                         : 3006: Tools.code_github_get(repo=sourceName, account=self.account, branch=self.branch, pull=pull)
        /tmp/InstallTools.py                                         : 1808: raise RuntimeError("Could not checkout branch:%s on %s" % (branch, args["REPO_DIR"]))

Mon 29 12:55:44 core.py          - 762 -                                    : EXCEPTION: Could not checkout branch:development_builders on /sandbox/code/github/threefoldtech/digitalmeX
CANNOT CONTINUE
Connection to localhost closed.

EXCEPTION

        /tmp/jsx                                                     : 587 : cli()
        /usr/lib/python3/dist-packages/click/core.py                 : 722 : return self.main(*args, **kwargs)
        /usr/lib/python3/dist-packages/click/core.py                 : 697 : rv = self.invoke(ctx)
        /usr/lib/python3/dist-packages/click/core.py                 : 1066: return _process_result(sub_ctx.command.invoke(sub_ctx))
        /usr/lib/python3/dist-packages/click/core.py                 : 895 : return ctx.invoke(self.callback, **ctx.params)
        /usr/lib/python3/dist-packages/click/core.py                 : 535 : return callback(*args, **kwargs)
        /tmp/jsx                                                     : 253 : docker.jumpscale_install(branch=branch, redo=reinstall, pull=pull, web=web)
        /tmp/InstallTools.py                                         : 3567: self.sshexec(cmd)
        /tmp/InstallTools.py                                         : 3404: Tools.execute(cmd2, interactive=True, showout=False, replace=False, asfile=True)
        /tmp/InstallTools.py                                         : 1259: original_command=command,
        /tmp/InstallTools.py                                         : 1266: res = Tools._execute_interactive(cmd=command, die=die, original_command=original_command)
        /tmp/InstallTools.py                                         : 671 : % (original_command, returncode)

Mon 29 12:55:44 core.py          - 720 -                                    : EXCEPTION: ***ERROR EXECUTE INTERACTIVE:
Could not execute:ssh -oStrictHostKeyChecking=no -t root@localhost -A -p 9122 'cd /tmp;python3 jsx install --branch development_builders'
returncode:1

waleedhammam commented 5 years ago

Will checkout the passed parameter, if it's not available on digitalme will checkout development_jumpscale. commit: https://github.com/threefoldtech/jumpscaleX/commit/61d8182b39eb4ce9a10ecd8c0c88213a50637193

Dinaamagdy commented 5 years ago

verified using developmemnt_builders branch

interactive:insystem/docker

threefoldtecharchive / jumpscaleX_archived

jumpscale installer needs to have the branch parameterized #737