threefoldtecharchive / jumpscaleX_archived

Apache License 2.0
1 stars 6 forks source link

confusing between development_jumpscale and development_builders branches #745

Closed Dinaamagdy closed 5 years ago

Dinaamagdy commented 5 years ago

There are things works on development_builder but don't work on development_jumpscale and vice versa As Example :

caddy builder

in development_builders :

j.builders.web.caddy.build() : works j.builders.web.caddy.start() : fails due this issue https://github.com/threefoldtech/jumpscaleX/issues/728 and this issue solved on development_jumpscale not in development_builders

in development_jumpscale:

j.builders.web.caddy.build() : fail and all other builders with the following error:

JSX> j.builders.web.caddy.build(reset=True)                                                          
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/sandbox/lib/jumpscale/Jumpscale/builders/builder/web/BuilderWebFactory.py", line 44, in caddy
    from .BuilderCaddy import BuilderCaddy
  File "/sandbox/lib/jumpscale/Jumpscale/builders/builder/web/BuilderCaddy.py", line 2, in <module>
    from Jumpscale.builder.runtimes.BuilderGolang import BuilderGolangTools
ModuleNotFoundError: No module named 'Jumpscale.builder'
rkhamis commented 5 years ago

@Dinaamagdy fixed. Please try again, and please use development_jumpscale as it has the latest fixes

Dinaamagdy commented 5 years ago

worked on development_jumpscale

Steps

and both works well