Review coredns builder - Githubissues

threefoldtecharchive / jumpscaleX_archived

Apache License 2.0

1 stars 6 forks source link

Review coredns builder #802

Open xmonader opened 4 years ago

xmonader commented 4 years ago

use redis config only
make sure it builds
make sure to disable systemd-resolved service

ranatrk commented 4 years ago

Checks:

On a new machine :
- installed jumpscalex
- built and installed coredns j.builders.network.install()
in install() of builder coredns systemd-resolved service is stopped https://github.com/threefoldtech/jumpscaleX/blob/development_jumpscale/Jumpscale/builders/network/BuilderCoreDns.py#L65
redis running on '127.0.0.1:6379`

Fixes:

removed etcd from builder, removed from builder test (To be implemented later) https://github.com/threefoldtech/jumpscaleX/commit/c4949e55ca3c66b91c33546ba27f244b8662bad9