threefoldtecharchive / jumpscaleX_core

Apache License 2.0
1 stars 6 forks source link

Error in worker running for first time [unstable] #518

Closed waleedhammam closed 4 years ago

waleedhammam commented 4 years ago

How to reproduce

on branch unstable

Screenshot from 2020-02-10 18-18-42

despiegk commented 4 years ago

this should bever be b'OK' where is this code, please next time also mention where screenshot is from

I found the code its in BCDBModelClient.get

this means it contacts the threebot server, is this the case? is the threebot server active? why is 'OK' coming back this should not be the case

there should be data coming back from the BCDB on the threebotserver

investigate more and let me know please

andrewayoub commented 4 years ago

we found that the unwanted b'OK' response is coming from set method in RedisServer.py line 253: image

after removing the new check and return the id in both cases it worked, but I'm not sure if that's a good fix.

andrewayoub commented 4 years ago

I pushed the fix here: https://github.com/threefoldtech/jumpscaleX_core/commit/a1b383becd5f77046f43e87261b3039425e06718

hossnys commented 4 years ago

verified on branch unstable

Screenshot from 2020-02-13 09-42-37

Screenshot from 2020-02-13 09-46-33