threefoldtecharchive / jumpscaleX_core

Apache License 2.0
1 stars 6 forks source link

make explorer address configurable per network #587

Closed zaibon closed 4 years ago

zaibon commented 4 years ago

It seems at the moment the address of the explorer for the grid is hardcoded to explorer.testnet.grid.tf: https://github.com/threefoldtech/jumpscaleX_core/blob/cd95aa6b6f8b4c91b979295b3d51a10ae543be1a/install/InstallTools.py#L3538-L3541

This needs to change and make it configurable by the user. He must be able to choose to which network he talks any point in time.

A simple config should allow the user to switch to a different network and everything should just keep working

zaibon commented 4 years ago

@xmonader @rkhamis @tobiaschielens @jdelrue If you guys have location you know we have hardcoded value for the explorer address, please write them down here.

tobiaschielens commented 4 years ago

One for the frontend: https://github.com/threefoldtech/jumpscaleX_threebot/blob/4392ac8c87b43975151cfb344455eefeaba78f43/ThreeBotPackages/threebot/farmmanagement/html/config/farmmanagement.config.local.js#L2

xmonader commented 4 years ago
grimpy commented 4 years ago

Does farmanagement cope with a change today?

grimpy commented 4 years ago

https://github.com/threefoldtech/jumpscaleX_threebot/blob/development/ThreeBotPackages/threebot/farmmanagement/actors/farm_management.py#L6

answering my own question since it's using the default client it should switch automaticly

Pishoy commented 4 years ago

verifed as below

JSX> j.clients.explorer.default_addr_set("explorer.grid.tf") 

JSX> j.me.configure() 
JSX> j.me.tfgrid_phonebook_register()