threefoldtecharchive / jumpscaleX_core

Apache License 2.0
1 stars 6 forks source link

Import export Error #596

Closed waleedhammam closed 4 years ago

waleedhammam commented 4 years ago

How to reproduce

after @zaibon suggested adding https://github.com/threefoldtech/jumpscaleX_core/blob/9bada8d884a4e07f2118e91f89d4a9ced0c7f713/JumpscaleCore/data/bcdb/BCDB.py#L566

you will get the following error Screenshot from 2020-03-10 16-30-45

rkhamis commented 4 years ago

This breaks the storclient interface, the fix done in this commit needs to be refactored to keep all the storclients consistent with the interface:

https://github.com/threefoldtech/jumpscaleX_core/commit/e8ca3d939aa98472300afdcd482e48d8fe38f442

zaibon commented 4 years ago

Where is the storclient interface defined ?

RafyAmgadBenjamin commented 4 years ago

Fixed: commits: cad68ae7c52ee4f54965453238bebef36c80f76c https://github.com/threefoldtech/jumpscaleX_threebot/commit/60793aceabe356725408f38048fe8ead7abfb9d6

Dina-Abd-Elrahman commented 4 years ago

Verified on unstable branch.

Scenarios 1 export and import database

Scenarios 2 change in bcdb and export then import

Verification steps:

Scenarios 1

Scenarios 2