Make cloning via https less ugly

threefoldtecharchive / jumpscaleX_core

Apache License 2.0

1 stars 6 forks source link

Make cloning via https less ugly #818

Closed grimpy closed 4 years ago

grimpy commented 4 years ago

This is most likely caused by try / except in a loop https://github.com/threefoldtech/jumpscaleX_core/blob/development/install/threesdk/InstallTools.py#L4997

We should detect before going in the loop which of the 2 methods we want to use (git ls-remote could be used to check)

Make sure that in code_github_get we always use the url passed not rely on what is configured in .git/config url

uglyclone

grimpy commented 4 years ago

The authenticity of host 'github.com (140.82.118.4)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? yes

This should now be asked

Dina-Abd-Elrahman commented 4 years ago

verified.