threefoldtecharchive / jumpscaleX_core

Apache License 2.0
1 stars 6 forks source link

Secret containing special characters make fail local container encryption #872

Closed archit3kt closed 4 years ago

archit3kt commented 4 years ago

Hi, during my first threebot start launch, I specified a secret with special characters

Here is the command line result :

"...

/tmp/script_dockerexecutor.sh: line 5: %{LHs!: No such file or directory /tmp/script_dockerexecutor.sh: line 5: 9X/Jf:: No such file or directory

Could not execute: docker exec -ti 3bot bash -c 'bash -e /tmp/scipt_dockerexecutor.sh' "

After this, loading again threebot start from "- make sure jumpscale code is on local filesystem" and fails again with the same error message. Any guidance ?

Btw, why can't we copy paste from the shell ?

archit3kt commented 4 years ago

Loading in expert mode and stopping the working container allowed me to put once again the good arguments (secret without special characters) to create the threebot container.

Still there should be a check on allowed characters when we specify the secret

grimpy commented 4 years ago

This is an escaping bug, all kind of characters should be allowed

Dina-Abd-Elrahman commented 4 years ago