search

threefoldtecharchive / jumpscaleX_core

Apache License 2.0
1 stars 6 forks source link

3sdk: explorer argument doesn't reflect in installation #894

Closed AhmedHanafy725 closed 4 years ago

AhmedHanafy725 commented 4 years ago

Steps

1- Download latest binary from releases. 2- Start 3sdk. 3- Set explorer argument.

args explorer val=none

4- Start threebot.

threebot start

Expected Result

don't ask for identity as explorer is none.

Actual Result

image

BolaNasr commented 4 years ago

Commit : https://github.com/threefoldtech/jumpscaleX_core/commit/5db8c53df5bd5271a4727cfaaad2bca4fa1a202f

AhmedHanafy725 commented 4 years ago

It didn't ask for identity at that point, but it asks for after creating the container.

image

BolaNasr commented 4 years ago

Fixed https://github.com/threefoldtech/jumpscaleX_core/commit/4a29853a45e192aee645638d46c4aaac0bd4baeb

AhmedHanafy725 commented 4 years ago

Verified Branch:: development Commit: 4a29853a45e192aee645638d46c4aaac0bd4baeb

image