threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

need to update webinterface tests [development_fixes_2] #316

Closed Dinaamagdy closed 4 years ago

Dinaamagdy commented 4 years ago

web_interfaces tests here need to be updates to be applicable with the new changes

https://github.com/threefoldtech/jumpscaleX_threebot/blob/development/ThreeBotPackages/zerobot/webinterface/package.py#L72

ranatrk commented 4 years ago

Issue: the functions in the package.py class in webinterface are not accessible from the package

xmonader commented 4 years ago

@ranatrk try using jslocation for that package and do jsx generate

ranatrk commented 4 years ago

@ranatrk try using jslocation for that package and do jsx generate

@xmonader a jslocation can't be added to a Package directly. I am considering creating a seperate j.baseclasses.object with the jslocation and the test implemented inside it.

ranatrk commented 4 years ago

WIP: changing the flow of the test as many things should be changed:

ranatrk commented 4 years ago

Fixes done in test_package used in the web interface test: https://github.com/threefoldtech/jumpscaleX_core/commit/6df9fcd1c7007a3987bf33988cb75abcb06b6e29

ranatrk commented 4 years ago

test now accessible from j.tools.packages.webinterface.test() https://github.com/threefoldtech/jumpscaleX_threebot/commit/8073c1d95aa9a98eb6e592e81b9ac4d6c52bc669