threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

exclude essential packages from stop/delete in packagemanager ui #502

Closed xmonader closed 4 years ago

xmonader commented 4 years ago

https://github.com/threefoldtech/jumpscaleX_core/blob/018395f859212d7a4392faed28052abe7d23b083/JumpscaleCore/servers/threebot/ThreebotServer.py#L394-L395

to keep 3bot functionality we should never disable e.g webinterface

abom commented 4 years ago

We can protected this on actor level, and also make them read-only inside the UI.

dmahmouali commented 4 years ago

commit: https://github.com/threefoldtech/jumpscaleX_threebot/commit/ae17172fbd0437bd047f466e8effb09dbfeb10c4

added condition for essential packages in actor and handled in frontend :

xmonader commented 4 years ago

there's no zerobot.alerta or zerobot.packagemanager packages anymore. should exculde admin, base, webinterface only.

dmahmouali commented 4 years ago

commit : https://github.com/threefoldtech/jumpscaleX_threebot/commit/3a8c67a299e25e4de0958f5d32c84b6a5540fc81 removerd zerobot.alerta package.

PeterNashaat commented 4 years ago

issue verified, packages webinterface, admin and base are locked.

Screen Shot 2020-04-27 at 10 45 23 PM