threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

package stop/delete package location and reload nginx #504

Closed xmonader closed 4 years ago

xmonader commented 4 years ago

expected

see install screen for codeserver

what happens

abom commented 4 years ago

The check for a package status in external view is wrong, it need to be fixed.

I think it would be better too if we can add an actor method to get certain package objects (required packages to be installed), then check their status directly instead of querying all packages like we do here:

https://github.com/threefoldtech/jumpscaleX_threebot/blob/294a2c70f47e428d702574c74873c3e3e7d7b66d/ThreeBotPackages/zerobot/admin/frontend_src/sources/views/external/index.js#L87-L110.

For the actual cleanup/stopping and reloading nginx conf, i think this cannot be done from our side, as every package maintainer defines his own website/locations configuration, also bottle servers or other services, so it needs to be implemented by package maintainers as stop, uninstall methods.

abom commented 4 years ago

Fixed loading packages at https://github.com/threefoldtech/jumpscaleX_core/commit/8ecc64145c5518d638ff4be3a77375b42ad40db0, also fixed checking for package status for external views at this commit: https://github.com/threefoldtech/jumpscaleX_threebot/commit/acc960fcbac06cd77f8888d25ebfa32e9f8ddcff, also it fixed start/stop of codeserver package itself too.

john-kheir commented 4 years ago

Can't install codeserver package .. not directly part of the issue but need to be handled
codeserver_error

john-kheir commented 4 years ago

was a problem with my docker .. Verified