threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

chat flow duration input improvement #637

Closed zaibon closed 4 years ago

zaibon commented 4 years ago

There needs to be some validation of the duration entered during chat flows.

The chat flows shows:

hour=h, day=d, week=w, month=M
I.e. 2 days = 2d

While you can enter things link 10m and it will count as 10 minutes.

m-motawea commented 4 years ago

PR: https://github.com/threefoldtech/jumpscaleX_core/pull/790

grimpy commented 4 years ago

Can we make it so if invliad data is enter we just ask again...

m-motawea commented 4 years ago

re-ask instead of error PR: https://github.com/threefoldtech/jumpscaleX_core/pull/791

AhmedHanafy725 commented 4 years ago

In case of combining two type time like I need 1 year and 2 months (1Y 2M), it works and it shouldn't as year is not supported.

image

grimpy commented 4 years ago

Please fix the validator and allow years (add in description aswell)

m-motawea commented 4 years ago

PR: https://github.com/threefoldtech/jumpscaleX_core/pull/792

AhmedHanafy725 commented 4 years ago

Verified

image

image

image

image

image

image

image