threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

chat flow duration: replace duration with date picker #638

Closed zaibon closed 4 years ago

zaibon commented 4 years ago

It is more intuitive for user to select an expiration date then a duration. Instead of asking to enter weird duration code, use a nice data picker.

waleedhammam commented 4 years ago

PR at: https://github.com/threefoldtech/jumpscaleX_threebot/pull/658 and https://github.com/threefoldtech/jumpscaleX_core/pull/801

Changelog

Screenshot from 2020-05-05 11-40-23 Screenshot from 2020-05-05 11-42-32




Screenshot from 2020-05-05 12-14-11

Screenshot from 2020-05-05 12-16-03

AhmedHanafy725 commented 4 years ago

As per https://github.com/threefoldtech/jumpscaleX_threebot/issues/637#issue-609955035 there was a limitation on duration to not be less than 1 hour, now I can set date After now by 1 minute, is the limitation not needed in the new date picker?

waleedhammam commented 4 years ago

As per #637 (comment) there was a limitation on duration to not be less than 1 hour, now I can set date After now by 1 minute, is the limitation not needed in the new date picker?

set at https://github.com/threefoldtech/jumpscaleX_core/commit/f22237e5574e55473308dcbfc21279e68e0330b6

Screenshot from 2020-05-06 10-11-46

AhmedHanafy725 commented 4 years ago

Verified Branch: rc_10.5.3 threebot commit: 67ce0d84b2c615bf515eaa1141c0b1fcd78bbbdc core commit: https://github.com/threefoldtech/jumpscaleX_core/commit/7d372250cb826cc070f90ac225df9b08f4810d35