search

threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

Chatflow for capa reservation doesn't work when node doesn't have a valid Stellar address #654

Closed gmachtel closed 4 years ago

gmachtel commented 4 years ago

If capacity is reserved on a node that doesn't have a public Stellar wallet address defined, reservation fails. So there should be filtering put in place to exclude these nodes.

On mainnet, this will lead to substantial reduction of valid nodes until 3Bot connect app wallet is released (later this week).

grimpy commented 4 years ago

image

Seems that even farms that have the 'TFT' address filled have bogus addresses... https://explorer.grid.tf/explorer/farms/1 https://horizon.stellar.org/accounts/GD3DUMWG2I2AD2ZVZ3KA77NQP75TXNUXWQXLCROGC4ANZ657RZENC6OD

I'm not sure how to progress from here... should we really validate those aswell?

gmachtel commented 4 years ago

I think these 'bogus' addresses were created before Stellar network reset. Best is to have all Stellar addresses deleted at the same time as Stellar testnet reset.

zaibon commented 4 years ago

There were address set there before we enabled validation of the address. Nothing to do with the stellar reset, we're talking mainnet here, there is no reset happening. I asked @andhartl to update the addresses on freefarm to put valid ones.

grimpy commented 4 years ago

Related: https://github.com/threefoldtech/tfexplorer/issues/51

Dinaamagdy commented 4 years ago

for TFT currency return the following error : image

Dinaamagdy commented 4 years ago

verified on branch rc_10.5.3