threefoldtecharchive / jumpscaleX_threebot

Apache License 2.0
0 stars 3 forks source link

Delete 'Create Wallet' button in 3sdk admin panel #757

Closed gmachtel closed 4 years ago

gmachtel commented 4 years ago

A user almost lost his tokens as he created a wallet in the admin panel but didn't write down the Stellar secret. He assumed that tokens would appear in 3Bot connect app.

image

In next 3Bot connect app, Stellar secret is shown in the wallet, this secret can be used for importing. Only keep 'import wallet' and delete 'create wallet' button will

BolaNasr commented 4 years ago

commit: https://github.com/threefoldtech/jumpscaleX_threebot/commit/1b2e0a628cfa15e048921a94fc8a2d6c39d5d862 image

zaibon commented 4 years ago

I think the approach to solve the issue encounter by the user is wrong. It seems the issue came from something the user just assume and that was never stated anywhere. It also could have been solved in other ways then simply deleting the feature all-together.

I would like we take a step back on this one and think about our other options. From the top of my head:

Dina-Abd-Elrahman commented 4 years ago