Propose our gateway implementation upstream

threefoldtecharchive / minio

Minio with 0-stor backend

Apache License 2.0

0 stars 0 forks source link

Propose our gateway implementation upstream #23

Open rkhamis opened 6 years ago

rkhamis commented 6 years ago

Issue migrated from [https://api.github.com/repos/gigforks/minio/issues/52](), opened by @zaibon

Make sure our code follow their guideline and then propose for a merge upstream.

rkhamis commented 6 years ago

*commented by @iwanbk We can't propose it as long as we are still using etcd as defaul metastor of 0-stor.

I was thinking of using 0-metadata as default meta stor, but that project seems not progressing for a long time.

Using badger and filemeta as default 0-stor metastor is not good way i think. We need something reliable for metadata storage. Otherwise we provide user with non-reliable default system.*

rkhamis commented 6 years ago

commented by @zaibon Agree. And we know that we don't want to use etcd anyhow.

rkhamis commented 6 years ago

*commented by @iwanbk Now working on this, need to do these:

once https://github.com/zero-os/0-stor/pull/539 got merged, update the vendoring and do all necessary fixes. Should be easy, as mostly about renaming because of API changes. And make sure that etcd & grpc is not vendored anymore
check that our gateway code already follow minio standard / guideline. I already followed coding style of other gateways, but better to re-check again.
make sure our code has enough test. It is already has much more test coverage than other gateways, but more coverage is better

Instead of using current (zerostor) branch to send PR, we might need to create fresh branch. Because current branch has a lot of histories, that might not wanted by minio devs. *

rkhamis commented 6 years ago

commented by @zaibon Sounds good

rkhamis commented 6 years ago

*commented by @iwanbk

0-stor has been updated
passed the make verifiers

Now add the encryption to metadata, as reported at #58*

rkhamis commented 6 years ago

*commented by @iwanbk did rebase from upstream, just before proposing the PR.

Got many errors, noticed changes:

errros package was removed
cmd.NewLogger was removed, there is new logger package
BucketPolicy API change.

Now working on the required changes. estimation : 1-2h

Also saw that another gateway has new features : drive cache. Should adapt our gateway to this. estimation : - *

rkhamis commented 6 years ago

*commented by @iwanbk

BucketPolicy API change. Now working on the required changes. estimation : 1-2h

The BucketPolicy change is very confusing, two gateways i saw only allow to set policy to read only.

Now our bucket policy test is broken

Also saw that another gateway has new features : drive cache. Should adapt our gateway to this. estimation : -

haven't tested it yet, but it seems that the cache functionality is fully handled by minio, transparent from the gateway implementation. So, we need to do almost nothing for this, only need to add the related help message. *

rkhamis commented 6 years ago

*commented by @iwanbk

The BucketPolicy change is very confusing, two gateways i saw only allow to set policy to read only.

Now our bucket policy test is broken

The bucket policy change was only done 2 days ago at https://github.com/gigforks/minio/commit/0d521260237ca69a89044f23f10a13b44e1f53c9

And it seems that the functionality is indeed still broken. Tested with :

official minio client (mc)
alibaba object storage service gateway*

rkhamis commented 6 years ago

commented by @zaibon is there already a PR on minio repo to propose our gateway ?