search

threefoldtecharchive / rivine

Blockchain technology for creating custom chains.
Apache License 2.0
22 stars 12 forks source link

validate if #61 is present in Sia #101

Open robvanmieghem opened 6 years ago

GlenDC commented 6 years ago

Sia does not seem to have the changes applied in https://github.com/rivine/rivine/pull/72/files#diff-cc3103986703bcfc324ae6d1da4c8921 (dbRemoveCoinOutput and dbAddCoinOutput).

So perhaps that fix wasn't really the correct fix, or perhaps Sia has the bug as well, or for some reason only we suffer from that bug, and that fix is either correct or it is not.

LeeSmet commented 6 years ago

I checked the sia code at the time i made the fix, they indeed did not have such behaviour. So I did a quick search through the open and closed issues, did not find anything related. Since sia is a has a reasonable userbase, it would be strange if they have the same bug but nobody noticed it or cared to file a bug report. This is why I thought the bug might have been caused by the modifications applied for rivine itself

GlenDC commented 6 years ago

This is why I thought the bug might have been caused by the modifications applied for rivine itself

Seems indeed like a reasonable assumption. Which made me wonder if our fix for that issue is the correct one.

robvanmieghem commented 6 years ago

I noticed when merging in the Sia changes that some changes have been made there (like https://github.com/rivine/rivine/commit/2f9257e2afe4913a8715c91de91270d515448c96) After merging in the rest , need to validate if the fix is still needed and if so, why.