search

threefoldtecharchive / rivine

Blockchain technology for creating custom chains.
Apache License 2.0
22 stars 12 forks source link

Create a multisignature extension #506

Closed robvanmieghem closed 5 years ago

robvanmieghem commented 5 years ago

tfchain implements multisignature functionality, this is useful for other chains as well so it would be good to put it in the Rivine extensions package.

LeeSmet commented 5 years ago

@robvanmieghem multisignature outputs are already part of the standard rivine conditions, see https://github.com/threefoldtech/rivine/blob/master/types/unlockcondition.go

GlenDC commented 5 years ago

Yes, they were always standard Rivine code. Reason of your confusion might be because we override them in tfchain, but that is only because we made this condition only available since a specific block height, as the tfchain launched when Rivine didn't have multisig in place yet.

Closing this as such an extension is not required as it is already part of the standard Rivine code.

robvanmieghem commented 5 years ago

thanks @GlenDC

robvanmieghem commented 5 years ago

@GlenDC since we are way past that blocklimit now, can't we drop that code from tfchain?

GlenDC commented 5 years ago

Yes, we could, feel free to add it to rivine/tfchain improvements.

robvanmieghem commented 5 years ago

https://github.com/threefoldfoundation/tfchain/issues/332