threefoldtecharchive / rivine

Blockchain technology for creating custom chains.
Apache License 2.0
22 stars 12 forks source link

Feat/tx validation v2 #560

Closed GlenDC closed 5 years ago

GlenDC commented 5 years ago

Closes #556, closes #559, closes #552

LeeSmet commented 5 years ago

Pushing an unsigned authorization tx:

command used: `goldchainc wallet send transaction $(goldchainc wallet authcoin authaddresses -e 01bd6d7c2fef2517d2e81ee325a8214e4484c94ed1fe76c9054730af5b3b81358c5c28260b447a)
Could not publish transaction: no response from daemon

output in daemon console:

goroutine 103 [running]:
runtime/debug.Stack(0x91ae7c, 0xc000336000, 0xc000114280)
    /usr/lib/go/src/runtime/debug/stack.go:24 +0xab
runtime/debug.PrintStack()
    /usr/lib/go/src/runtime/debug/stack.go:16 +0x34
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build.Severe(0xc000114318, 0x1, 0x1)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build/critical.go:27 +0x8c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.(*NilFulfillment).Marshal(0x13b4710, 0xd3af40, 0x4be21c, 0xc000114388, 0xbe4385)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:687 +0x84
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.UnlockFulfillmentProxy.MarshalRivine(0xe2e900, 0x13b4710, 0x7fafa4202050, 0xc000476180, 0x432d23, 0xc56f20)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:2146 +0xab
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xcaf7e0, 0xc0000ac770, 0x99, 0xcaf7e0, 0xc0000ac770)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:88 +0x172a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x99, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:166 +0x1a2
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).Encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:59 +0x5d
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).EncodeAll(0xc000114958, 0xc000114978, 0x2, 0x2, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:65 +0x8a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx.AuthAddressUpdateTransactionController.EncodeTransactionIDInput(0xe2b380, 0xc00006c4c0, 0xb0, 0x7fafa4202050, 0xc000476180, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx/transactions.go:280 +0x322
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.encodeTransactionDataAsIDInput(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:218 +0x2b9
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.ID(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:168 +0x12c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet.func1(0xc0003ec0e0, 0xd3abd0, 0xc0003ec0e0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:197 +0x1d4
github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt.(*DB).Update(0xc00000c3c0, 0xc0001155b0, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt/db.go:677 +0xb7
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet(0xc000374480, 0x13b4710, 0x0, 0x0, 0xa8, 0xa8)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:193 +0x16c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).AcceptTransactionSet(0xc000374480, 0xc0003d20b0, 0x1, 0x1, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:264 +0xcf
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.NewTransactionPoolPostTransactionHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200, 0x0, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/transactionpool.go:146 +0x2c2
github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc00006c080, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter/router.go:334 +0x107e
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.RequireUserAgentHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/http.go:88 +0x101
net/http.HandlerFunc.ServeHTTP(0xc0004907e0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:1995 +0x52
net/http.(*ServeMux).ServeHTTP(0xc0000aea40, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:2375 +0x28b
net/http.serverHandler.ServeHTTP(0xc0002008f0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:2774 +0xcf
net/http.(*conn).serve(0xc0002fa000, 0xe2b180, 0xc00029a1c0)
    /usr/lib/go/src/net/http/server.go:1878 +0x812
created by net/http.(*Server).Serve
    /usr/lib/go/src/net/http/server.go:2884 +0x4c5
Severe error: nil fulfillment type
2019/07/26 09:47:00 http: panic serving 127.0.0.1:41194: Severe error: nil fulfillment type

goroutine 103 [running]:
net/http.(*conn).serve.func1(0xc0002fa000)
    /usr/lib/go/src/net/http/server.go:1769 +0x147
panic(0xc16500, 0xc00005a080)
    /usr/lib/go/src/runtime/panic.go:522 +0x1b5
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build.Severe(0xc000114318, 0x1, 0x1)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build/critical.go:30 +0x128
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.(*NilFulfillment).Marshal(0x13b4710, 0xd3af40, 0x4be21c, 0xc000114388, 0xbe4385)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:687 +0x84
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.UnlockFulfillmentProxy.MarshalRivine(0xe2e900, 0x13b4710, 0x7fafa4202050, 0xc000476180, 0x432d23, 0xc56f20)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:2146 +0xab
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xcaf7e0, 0xc0000ac770, 0x99, 0xcaf7e0, 0xc0000ac770)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:88 +0x172a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x99, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:166 +0x1a2
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).Encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:59 +0x5d
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).EncodeAll(0xc000114958, 0xc000114978, 0x2, 0x2, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:65 +0x8a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx.AuthAddressUpdateTransactionController.EncodeTransactionIDInput(0xe2b380, 0xc00006c4c0, 0xb0, 0x7fafa4202050, 0xc000476180, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx/transactions.go:280 +0x322
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.encodeTransactionDataAsIDInput(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:218 +0x2b9
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.ID(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:168 +0x12c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet.func1(0xc0003ec0e0, 0xd3abd0, 0xc0003ec0e0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:197 +0x1d4
github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt.(*DB).Update(0xc00000c3c0, 0xc0001155b0, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt/db.go:677 +0xb7
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet(0xc000374480, 0x13b4710, 0x0, 0x0, 0xa8, 0xa8)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:193 +0x16c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).AcceptTransactionSet(0xc000374480, 0xc0003d20b0, 0x1, 0x1, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:264 +0xcf
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.NewTransactionPoolPostTransactionHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200, 0x0, 0x0, 0x0)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/transactionpool.go:146 +0x2c2
github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc00006c080, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter/router.go:334 +0x107e
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.RequireUserAgentHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200)
    /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/http.go:88 +0x101
net/http.HandlerFunc.ServeHTTP(0xc0004907e0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:1995 +0x52
net/http.(*ServeMux).ServeHTTP(0xc0000aea40, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:2375 +0x28b
net/http.serverHandler.ServeHTTP(0xc0002008f0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
    /usr/lib/go/src/net/http/server.go:2774 +0xcf
net/http.(*conn).serve(0xc0002fa000, 0xe2b180, 0xc00029a1c0)
    /usr/lib/go/src/net/http/server.go:1878 +0x812
created by net/http.(*Server).Serve
    /usr/lib/go/src/net/http/server.go:2884 +0x4c5
GlenDC commented 5 years ago

Pushing an unsigned authorization tx:

command used: `goldchainc wallet send transaction $(goldchainc wallet authcoin authaddresses -e 01bd6d7c2fef2517d2e81ee325a8214e4484c94ed1fe76c9054730af5b3b81358c5c28260b447a)
Could not publish transaction: no response from daemon

output in daemon console:

goroutine 103 [running]:
runtime/debug.Stack(0x91ae7c, 0xc000336000, 0xc000114280)
  /usr/lib/go/src/runtime/debug/stack.go:24 +0xab
runtime/debug.PrintStack()
  /usr/lib/go/src/runtime/debug/stack.go:16 +0x34
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build.Severe(0xc000114318, 0x1, 0x1)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build/critical.go:27 +0x8c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.(*NilFulfillment).Marshal(0x13b4710, 0xd3af40, 0x4be21c, 0xc000114388, 0xbe4385)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:687 +0x84
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.UnlockFulfillmentProxy.MarshalRivine(0xe2e900, 0x13b4710, 0x7fafa4202050, 0xc000476180, 0x432d23, 0xc56f20)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:2146 +0xab
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xcaf7e0, 0xc0000ac770, 0x99, 0xcaf7e0, 0xc0000ac770)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:88 +0x172a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x99, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:166 +0x1a2
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).Encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:59 +0x5d
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).EncodeAll(0xc000114958, 0xc000114978, 0x2, 0x2, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:65 +0x8a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx.AuthAddressUpdateTransactionController.EncodeTransactionIDInput(0xe2b380, 0xc00006c4c0, 0xb0, 0x7fafa4202050, 0xc000476180, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx/transactions.go:280 +0x322
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.encodeTransactionDataAsIDInput(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:218 +0x2b9
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.ID(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:168 +0x12c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet.func1(0xc0003ec0e0, 0xd3abd0, 0xc0003ec0e0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:197 +0x1d4
github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt.(*DB).Update(0xc00000c3c0, 0xc0001155b0, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt/db.go:677 +0xb7
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet(0xc000374480, 0x13b4710, 0x0, 0x0, 0xa8, 0xa8)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:193 +0x16c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).AcceptTransactionSet(0xc000374480, 0xc0003d20b0, 0x1, 0x1, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:264 +0xcf
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.NewTransactionPoolPostTransactionHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200, 0x0, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/transactionpool.go:146 +0x2c2
github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc00006c080, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter/router.go:334 +0x107e
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.RequireUserAgentHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/http.go:88 +0x101
net/http.HandlerFunc.ServeHTTP(0xc0004907e0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:1995 +0x52
net/http.(*ServeMux).ServeHTTP(0xc0000aea40, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:2375 +0x28b
net/http.serverHandler.ServeHTTP(0xc0002008f0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:2774 +0xcf
net/http.(*conn).serve(0xc0002fa000, 0xe2b180, 0xc00029a1c0)
  /usr/lib/go/src/net/http/server.go:1878 +0x812
created by net/http.(*Server).Serve
  /usr/lib/go/src/net/http/server.go:2884 +0x4c5
Severe error: nil fulfillment type
2019/07/26 09:47:00 http: panic serving 127.0.0.1:41194: Severe error: nil fulfillment type

goroutine 103 [running]:
net/http.(*conn).serve.func1(0xc0002fa000)
  /usr/lib/go/src/net/http/server.go:1769 +0x147
panic(0xc16500, 0xc00005a080)
  /usr/lib/go/src/runtime/panic.go:522 +0x1b5
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build.Severe(0xc000114318, 0x1, 0x1)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/build/critical.go:30 +0x128
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.(*NilFulfillment).Marshal(0x13b4710, 0xd3af40, 0x4be21c, 0xc000114388, 0xbe4385)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:687 +0x84
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.UnlockFulfillmentProxy.MarshalRivine(0xe2e900, 0x13b4710, 0x7fafa4202050, 0xc000476180, 0x432d23, 0xc56f20)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/unlockcondition.go:2146 +0xab
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xcaf7e0, 0xc0000ac770, 0x99, 0xcaf7e0, 0xc0000ac770)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:88 +0x172a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x99, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:166 +0x1a2
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).Encode(0xc000114958, 0xca93a0, 0xc0000ac720, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:59 +0x5d
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin.(*Encoder).EncodeAll(0xc000114958, 0xc000114978, 0x2, 0x2, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/encoding/rivbin/encode.go:65 +0x8a
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx.AuthAddressUpdateTransactionController.EncodeTransactionIDInput(0xe2b380, 0xc00006c4c0, 0xb0, 0x7fafa4202050, 0xc000476180, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/extensions/authcointx/transactions.go:280 +0x322
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.encodeTransactionDataAsIDInput(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:218 +0x2b9
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types.Transaction.ID(0xb0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/types/transactions.go:168 +0x12c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet.func1(0xc0003ec0e0, 0xd3abd0, 0xc0003ec0e0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:197 +0x1d4
github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt.(*DB).Update(0xc00000c3c0, 0xc0001155b0, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/rivine/bbolt/db.go:677 +0xb7
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).acceptTransactionSet(0xc000374480, 0x13b4710, 0x0, 0x0, 0xa8, 0xa8)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:193 +0x16c
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool.(*TransactionPool).AcceptTransactionSet(0xc000374480, 0xc0003d20b0, 0x1, 0x1, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/modules/transactionpool/accept.go:264 +0xcf
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.NewTransactionPoolPostTransactionHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200, 0x0, 0x0, 0x0)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/transactionpool.go:146 +0x2c2
github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc00006c080, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/julienschmidt/httprouter/router.go:334 +0x107e
github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api.RequireUserAgentHandler.func1(0xe29540, 0xc0003ec000, 0xc0002d4200)
  /home/lee/go/src/github.com/nbh-digital/goldchain/vendor/github.com/threefoldtech/rivine/pkg/api/http.go:88 +0x101
net/http.HandlerFunc.ServeHTTP(0xc0004907e0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:1995 +0x52
net/http.(*ServeMux).ServeHTTP(0xc0000aea40, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:2375 +0x28b
net/http.serverHandler.ServeHTTP(0xc0002008f0, 0xe29540, 0xc0003ec000, 0xc0002d4200)
  /usr/lib/go/src/net/http/server.go:2774 +0xcf
net/http.(*conn).serve(0xc0002fa000, 0xe2b180, 0xc00029a1c0)
  /usr/lib/go/src/net/http/server.go:1878 +0x812
created by net/http.(*Server).Serve
  /usr/lib/go/src/net/http/server.go:2884 +0x4c5

This is expected behaviour and is part of Rivine since the launch of tfchain. I do agree that this is dirty and should be fixed once and for all. Will resolve it as a separate PR and issue https://github.com/threefoldtech/rivine/issues/561, as this is a very invasive change.