threefoldtecharchive / tfchain_activation_service

Apache License 2.0
1 stars 0 forks source link

The production docker image uses dev dependencies #20

Closed robvanmieghem closed 1 year ago

robvanmieghem commented 1 year ago

The command in the docker image executes the start script which requires nodemon and pino-pretty which are both dev dependencies

robvanmieghem commented 1 year ago

nodemon does not seem needed to me as it is meant to reload changes in the code on the fly. pino-pretty does seem required as we only log to stdout and pino by default logs in json format is seems. @DylanVerstraete your thoughts?

DylanVerstraete commented 1 year ago

Maybe it should not do that, we can have a seperate command to start in production

DylanVerstraete commented 1 year ago

https://github.com/threefoldtech/tfchain_activation_service/pull/22

robvanmieghem commented 1 year ago

4954a5cb49450550812141349fcb7f74174cf993