search

threefoldtecharchive / tfchain_explorer

explorer UI for grid 3
https://explorer.dev.grid.tf
2 stars 0 forks source link

On helm deployment remove default dashboard.com ingress #159

Closed coesensbert closed 2 years ago

coesensbert commented 2 years ago

When deploying the explorer via helm we don't define an ingress, since there is already one configured. There is always a dashboard.com ingress created. Could this be disabled? Or is there another way to disable on each deployment/upgrade?

image

RafyAmgadBenjamin commented 2 years ago

sorry, I don't understand what you mean exactly, do you want to remove the default value for the domain in ingress ? or do you want to stop ingress itself in the helm chart ???

coesensbert commented 2 years ago

I think removing ingress from the helm chart will be the quickest fix. It's just a minor annoyance now since we don't define an ingress when deploying / upgrading the explorer, but a dashboard.com ingress is created every time.

RafyAmgadBenjamin commented 2 years ago

Done

Branch

master_disable_ingress

PR

https://github.com/threefoldtech/tfchain_explorer/pull/172

RafyAmgadBenjamin commented 2 years ago

After more discussion, we decided to keep ingress enabled and as you handle this with external ingress you can disable helm ingress bypassing to is --set.ingress.enabled=false

coesensbert commented 2 years ago

Aha that is also good! Did not know. Will test with next release. Thx!