threefoldtecharchive / tfchain_explorer

explorer UI for grid 3
https://explorer.dev.grid.tf
2 stars 0 forks source link

DIY label is not correct #191

Closed sabrinasadik closed 2 years ago

sabrinasadik commented 2 years ago

Titans are still being marked as DIY instead of certified on explorer V3. Graphql says otherwise, after running the certification script (see https://github.com/threefoldtech/tf_operations/issues/752)

asamirr commented 2 years ago

You mean the farms in https://explorerv3.grid.tf/farms ?

sabrinasadik commented 2 years ago

Yes

asamirr commented 2 years ago

I just checked https://graphql.grid.tf/graphql and when I ran the following query query MyQuery { farms { name certificationType } } found that all of them were DIY

sabrinasadik commented 2 years ago

My bad, I mean the nodes. Long day, apologies

MohamedElmdary commented 2 years ago

@sabrinasadik I think its working as expected image

sabrinasadik commented 2 years ago

Node ID 1293 - certified on GraphQL - DIY on explorer Screenshot 2022-03-29 at 17 07 18 photo_2022-03-29 17 07 45

sabrinasadik commented 2 years ago

photo_2022-03-29 17 09 23

asamirr commented 2 years ago

Just to clarify, are we talking about https://graphql.grid.tf/graphql ? Because if yes, and we're talking about the farm that it is the one that should be certified and it's shown as DIY in explorer, then I think we're not on the same page since graphql server returned this image

So it makes sense that the explorer is showing it as DIY

sabrinasadik commented 2 years ago

Shouldn't only nodes get a certification label? The farm shows DIY but the node certified? @rkhamis

sabrinasadik commented 2 years ago

Need to hide farm certification it's too confusing. https://github.com/threefoldtech/tfchain_explorer/issues/196

MohamedElmdary commented 2 years ago

Removed

PR

https://github.com/threefoldtech/tfchain_explorer/pull/213

mohamedamer453 commented 2 years ago

Verified on https://explorer.dev.grid.tf

Certification Type field was removed from the Farm Details

image