threefoldtecharchive / tfchain_explorer

explorer UI for grid 3
https://explorer.dev.grid.tf
2 stars 0 forks source link

Statistics on explorerv3.grid.tf seem to be off #192

Closed sabrinasadik closed 2 years ago

sabrinasadik commented 2 years ago

Numbers seem to be way different than on explorer.threefold.io

Screenshot 2022-03-28 at 18 14 11 Screenshot 2022-03-28 at 18 14 02
AhmedHanafy725 commented 2 years ago

The unified explorer on explorer.threefold.io is showing only the online nodes in the statistics view, but the grid3 explorer on explorerv3.grid.tf is showing all nodes(online + offline), so we need to make them work similarly

@sabrinasadik @rkhamis should we show online nodes only or all nodes on both? (in the statistics' view not the nodes' table)

rkhamis commented 2 years ago

i think we show the total number then we should show number of online nodes as well

so we add a statistic showing online nodes while the old one shows the total number of nodes connected to the grid

scottyeager commented 2 years ago

I'm not sure that total nodes is a relevant metric. Most offline nodes are duplicate entries for physical nodes which have gotten a new id. Farmers tend not to delete the old node ids in this case. Showing the total node count gives the wrong impression, that there are many physical nodes offline at any given point in time.

AhmedHanafy725 commented 2 years ago

as per discussion with @rkhamis, only online nodes will be shown on the statistics page.

mohamedamer453 commented 2 years ago

Verified on https://explorer.dev.grid.tf/

The statistics page now shows online nodes only and the number in the statistics page matches the number of online nodes in the nodes table.

19 online nodes in the statistics page

image

Also 19 online nodes in the nodes table

image

image

Also matches the number of online nodes on https://explorer.threefold.io/devnet

image