threefoldtecharchive / tfchain_portal

A frontend to interact with Tfchain
0 stars 2 forks source link

TF Portal invalid farmer Stellar address #68

Open mohamedamer453 opened 2 years ago

mohamedamer453 commented 2 years ago

Tested on devnet and testnet After creating a farm through the TF Portal. Adding an invalid Stellar payout address doesn't disable the save button and it actually saves the invalid address without errors

image

image

mohamedamer453 commented 2 years ago

Same issue happened with adding public IPs. The validation message is working but it doesn't disable The save button and it submits the address and gateway without any errors

image

image

xmonader commented 2 years ago

definitely an issue (y)

mohamedamer453 commented 2 years ago

Also the validation for the Twin IP in the portal is not working and when an invalid format is entered it doesn't even show a validation error message

image

and it just keeps loading for a long time without outputting anything and when interrupted and after refreshing the page the invalid input appears to be saved

image

After further testing there is no validation for almost anything on the TF Chain Portal.

Ex: you can create a farm without entering a farm name image

and it just keeps loading after you sign the transaction

image

another example is the Bridge TFT to Stellar tab

image

the validation for amount is working but for wallet address is not and proceeds with the window for signing the transaction. after proceeding with the transaction it does the same thing and just keeps loading without any result. and the TFT was actually withdrawn from the account to a nonexistent address.

finally in the transfer tab there is no validation for entering 0 for the amount

image

the validation is working here and the button is disabled but the error message is not user friendly at all.

image

and when a valid address is entered with an amount of 0 it proceeds with the transaction

image

and after signing the transaction again the same issue happens and it keeps loading without any output

image

mohamedamer453 commented 2 years ago

The new Validation for the IP Fields is mostly working but has 2 problems.

First Problem

The place holder ::1 is accepted as a correct input and doesn't disable the create button and can be accepted as a valid input.

image

image

Second problem

Before the First colon in the IP the validation is not working and the user can enter special characters and spaces.

image

image