threefoldtecharchive / tfgrid_dashboard

unified portal + explorer
1 stars 3 forks source link

use `cidr-tools` to validate gateway is inRange #538

Closed Omarabdul3ziz closed 1 year ago

Omarabdul3ziz commented 1 year ago

Changes

Related issues

Mahmoud-Emad commented 1 year ago

Based on testing, the issue is still there.

I tried a valid IP and it accepted and created

image

but it should accept only public IP, it should tell me that this is not a pub ip

image

and if I submit it, it fails.

image

image

Omarabdul3ziz commented 1 year ago

Actually 192.167.. is a valid public ip from class C. as well 1.1.1.1 from class A

The reserved Ips for private networks is

i tried it and it worked image

and the validation looks working on the out range IPs image

Can you re test it please?