threefoldtecharchive / tfgrid_dashboard

unified portal + explorer
1 stars 3 forks source link

Gateway should re-verify inputs if IP is changed #552

Closed A-Harby closed 1 year ago

A-Harby commented 1 year ago

Description

Gateway validation doesn't re-verify itself after IP is been added or changed, in adding IP to the farm.

Logs/Alerts

Untitled_ Mar 9, 2023 2_55 PM.webm

0oM4R commented 1 year ago

the rule only prop only applied on input, so the user has to re-enter the gateway, we can overcome this by making the gateway field disabled until the user enters a valid id

A-Harby commented 1 year ago

Also to be taken in consideration, there are cases in which a user can enter an IP to enable a gateway input, enter the gateway, and then change their IP. In this case, the gateway must be re-verified to the new IP, which is the same problem.

0oM4R commented 1 year ago

I set a watcher on the ip field to handle this scenario

A-Harby commented 1 year ago

Verified on Devnet, Gateway is now displayed until the IP is typed and validate correctly and even after that if gateway is changed, its validated again
image