search

threefoldtecharchive / tfgrid_dashboard

unified portal + explorer
1 stars 3 forks source link

enhance Dedicate node page #559

Closed 0oM4R closed 1 year ago

0oM4R commented 1 year ago

Description

This PR added several enhancements to Dedicate Nodes page

Changes

Related Issues

Checklist

Mahmoud-Emad commented 1 year ago

also, it still requests to get node information on the length of nodes, if there are 3 nodes it will request 3 times. I think it should be just once, should request on the mount to get all node's information, you can check if there is an endpoint that can return the whole result of the nodes in one, and search on it.

0oM4R commented 1 year ago

this got resolved in later PR, https://github.com/threefoldtech/tfgrid_dashboard/pull/563

also, it still requests to get node information on the length of nodes, if there are 3 nodes it will request 3 times. I think it should be just once, should request on the mount to get all node's information, you can check if there is an endpoint that can return the whole result of the nodes in one, and search on it.

Mahmoud-Emad commented 1 year ago

this got resolved in later PR, https://github.com/threefoldtech/tfgrid_dashboard/pull/565

image

Still has duplication

Mahmoud-Emad commented 1 year ago

Now the current performance is too bad/slow while the performance on development is better, its keep loading then after a few seconds it displays the data, please note that The request does not take all this time, the request responded faster as you see in the mentioned video, I assume you set timeout to wait then request, check again and try to find where is the issue, also the request to get nodes are executed 3 times as I mentioned above, it will request on len(Nodes) which is not good, try also to track it.

https://user-images.githubusercontent.com/57001890/225314668-3917e969-ed6e-4f3b-b905-dab3f1c68fde.mp4

0oM4R commented 1 year ago

Now the current performance is too bad/slow while the performance on development is better, its keep loading then after a few seconds it displays the data, please note that The request does not take all this time, the request responded faster as you see in the mentioned video, I assume you set timeout to wait then request, check again and try to find where is the issue, also the request to get nodes are executed 3 times as I mentioned above, it will request on len(Nodes) which is not good, try also to track it.

The changes was made on Dedicated nodes, try it on the dev or main net you will see a huge different :D

Mahmoud-Emad commented 1 year ago

Now the current performance is too bad/slow while the performance on development is better, its keep loading then after a few seconds it displays the data, please note that The request does not take all this time, the request responded faster as you see in the mentioned video, I assume you set timeout to wait then request, check again and try to find where is the issue, also the request to get nodes are executed 3 times as I mentioned above, it will request on len(Nodes) which is not good, try also to track it.

The changes was made on Dedicated nodes, try it on the dev or main net you will see a huge different :D

and what about the duplication?

0oM4R commented 1 year ago

Now the current performance is too bad/slow while the performance on development is better, its keep loading then after a few seconds it displays the data, please note that The request does not take all this time, the request responded faster as you see in the mentioned video, I assume you set timeout to wait then request, check again and try to find where is the issue, also the request to get nodes are executed 3 times as I mentioned above, it will request on len(Nodes) which is not good, try also to track it.

The changes was made on Dedicated nodes, try it on the dev or main net you will see a huge different :D

and what about the duplication? should be resolved in commit. image