threefoldtecharchive / vdc-solutions-charts

2 stars 2 forks source link

verify that all the solutions compute resource requirements set properly. #146

Open sameh-farouk opened 3 years ago

sameh-farouk commented 3 years ago

to acquire some context check: https://github.com/threefoldtech/js-sdk/issues/3186

after a discussion with @xmonader and @ashraffouda we need to: 1- make sure that every solution has a CPU and Memory request and a CPU and Memory limit set for its containers. (explicitly, or/and via a default value in the limit range, etc) 2- make sure that the total compute resource requirements for all pods/containers for that solution not exceed the amounts of resources in the picked flavor. one way this could be done via a formula in the helm templates. 3- verify via kubectl after the solution deployment that total requests and limits for all pods/containers don't violate the flavor constraint.

sameh-farouk commented 3 years ago

peertube:

  Namespace                   Name                                          CPU Requests  CPU Limits  Memory Requests  Memory Limits  AGE
  peertube-peer18072021       peertube-postgresql-peer18072021-0            250m (25%)    0 (0%)      256Mi (12%)      0 (0%)         60m
  peertube-peer18072021       peer18072021-peertube-7988cff86b-m4znx        900m (45%)    1 (50%)     1Gi (26%)        1Gi (26%)      43m
  peertube-peer18072021       peertube-redis-peer18072021-master-0          0 (0%)        0 (0%)      0 (0%)           0 (0%)         43m

observation:

PR: