search

threejs / three-devtools

three.js devtools
https://chrome.google.com/webstore/detail/threejs-developer-tools/ebpnegggocnnhleeicgljbedjkganaek
MIT License
603 stars 79 forks source link

Update webextension-polyfill to work in the most recent Chrome version #78

Open rafaelsc opened 2 years ago

rafaelsc commented 2 years ago

The old webextension-polyfill is causing issies with Chrome, making you need to refresh many times the page to the extentions start watching the scene.

mrdoob commented 2 years ago

Do we even need this polyfill? 🤔

rafaelsc commented 2 years ago

@mrdoob I don't know. I don't have too much experience with extensions. I tried to remove and look like the change would be bigger. And I only manage to make work upgrading the polyfill, changing the event to be onDOMContentLoaded.

zadinvit commented 2 years ago

This changes work fine. Thanks @rafaelsc. Please merge this to master.

rafaelsc commented 2 years ago

Sorry @zadinvit. I don't have permission to complete this PR (merging to master)