Latest update not released, getting annoyed by update pop-up

herpaderpaldent commented 4 months ago

This is a draft, waiting for the annoying alert to appear again

Bug Description

an annoying pop up always claims that a new update is available.
upon installing via ui OR installing the latest version from the threema homepage, the update info persists

it seems the latest version from early march has not been compiled as version for macOS

Steps to Reproduce (for bugs)

Have Threema Web App on Mac installed
Use Threema Web App
Get random update available prompt
Restart as prompted
Have the same version ....
download latest from homepage

Potential Solution

actually release 2.5.4 as download on your homepage

Your Environment

Threema Web version:
Threema App version:
Browser name and version:
Computer operating system and version:
Smartphone operating system and version:

threema-danilo commented 4 months ago

This affects Threema Desktop and not Threema Web, but thanks for the note, we'll take a look.

herpaderpaldent commented 4 months ago

Thank you @threema-danilo the version pop up lead me to this repository. I am sorry. Shall i recreate it on the other repo?

threema-danilo commented 4 months ago

@herpaderpaldent to summarize the repository structure:

https://github.com/threema-ch/threema-web/ is the actual implementation of the Threema web client. It is used both on web.threema.ch and is embedded in Threema 1.0 for desktop.
https://github.com/threema-ch/threema-web-electron/ is the Electron wrapper around Threema Web. This is where the update check happens.

We did not enable the issue tracker for the threema-web-electron repository, because we prefer if these requests are channelled through the regular support system (https://threema.ch/en/support-request). However, since this is now something that we've heard occasionally from a few people, let's keep the issue here for now.

Regarding your issue, in the two screenshots of the version, I can see that the actual upgrade did happen successfully, from 1.2.40 to 1.2.41. In both versions, the embedded version of Threema Web remains at 2.5.3 (2.5.4 will be included in the next release).

Do you still get the "update available" prompt?

thepatcher commented 3 months ago

I had the same issue with the pop-up, for months, but yesterday I downloaded the newest version from https://releases.threema.ch/web-electron/v1/release/Threema-Latest.dmg and now the version information says "Version 2.5.3 (1.2.41) Lütispitz" and the pop-up is gone.

herpaderpaldent commented 3 months ago

Hi @threema-danilo

Do you still get the "update available" prompt?

i can confirm just like @thepatcher, that with the latest version the prompts are gone with the 1.2.41. Somehow the upgrade via ui in contrast to downloading the .dmg did not occur.

threema-danilo commented 3 months ago

Thanks for the confirmation! It was probably an issue with a single release, where something went wrong in the build process. Manually updating should help.

threema-ch / threema-web