search

threemarb / threema

This gem provides access to the Threema Gateway API.
MIT License
11 stars 2 forks source link

Public Key Pinning should be configurable #1

Closed rugk closed 7 years ago

rugk commented 7 years ago

Does it use/support public key pinning?

Ref. https://github.com/rugk/threema-msgapi-sdk-php/issues/21, https://github.com/rugk/threema-msgapi-sdk-php/issues/49

rugk commented 7 years ago

Ah just saw https://github.com/thorsteneckel/threema/commit/acff602e33473bf30f829895c2885287bec1eb41, so you do support it? (Actually I think it should be configurable whether the user wants to use it or not)

thorsteneckel commented 7 years ago

Yes, it does :) I'll add a configuration for disabling it but I will keep it active by default.

Regarding your comment on the commit: Actually I was a bit in a hurry but wanted to get the tests running 😇 I got an Unauthorized exception in the Travis-CI run which needs further investigation.

Thanks for your participation!

thorsteneckel commented 7 years ago

Done with the commit above.