Closed roschaefer closed 3 years ago
Merging #28 (e003489) into master (ab6a373) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 36.62% 36.62%
=======================================
Files 13 13
Lines 344 344
=======================================
Hits 126 126
Misses 218 218
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ab6a373...e003489. Read the comment docs.
Hi @roschaefer - thanks for this. Can you elaborate Threema::Receive::NotImplementedFallback
a bit more. Why is this needed? A use case would be nice.
Okee, so I'm not supposed to change this code. @thorsteneckel could you also have a look at #29 and #30? They should have the nice side-effect on fixing the build.
Undraft and point the target branch to
master
once #26 is merged. The current target branch is just a convenience to make the diff a little smaller.I included a hotfix commit by @mattwr18 in this PR. Other than that, here's my commit message:
How could
DeliveryReceipt
class a little more useful?