Change bool pinning option to custom pinning string

threemarb / threema

This gem provides access to the Threema Gateway API.

MIT License

11 stars 2 forks source link

Change bool pinning option to custom pinning string #9

Closed rugk closed 3 years ago

rugk commented 7 years ago

I'd suggest to let the user define the hashes to pin by themselves instead, when they e.g. want to pin the cert of a HTTPS MITM box or so or when you forget to update the hash when Threema updates their certs. :wink:

An example can be seen here.

Ref https://github.com/thorsteneckel/threema/commit/5dfa6800628d25c052a62a539ed650a3bc7c15f1#commitcomment-21503456

roschaefer commented 3 years ago

I guess this can be closed after #24