search

threepointone / bs-nice

css-in-reason
180 stars 14 forks source link

no love for grid? :( #10

Open lpalmes opened 6 years ago

threepointone commented 6 years ago

are you up for annotating all the grid properties too?

lpalmes commented 6 years ago

i don’t know them but mozillla docs will help. i could them tomorrow if you don’t mind

threepointone commented 6 years ago

take all the time you need, no hurry for this

lpalmes commented 6 years ago

what do you feel about adding fr to the type dimension?

i was thinking about having gridTemplateRows and gridTemplateColumns as a list(dimensions), so then it can be used gridTemplateRows=[Px(200), Fr(1), Percentage(10.)]

my only concern about this is having fr available to other dimension like width, minWidth, etc, i think it only works in grid

ulrikstrid commented 6 years ago

I think you can extend the dimension type just for grid with Fr