threepointone / bs-nice

css-in-reason
180 stars 14 forks source link

Enable namespace in bucklescript config #17

Closed thangngoc89 closed 6 years ago

thangngoc89 commented 6 years ago

I want to propose this because currently, I can't get type information when working on nice.re file (this is a known limitation of bucklescript/merlin). I asked chenglou on Discord and he suggested that I should enable namespace (I have no ideas what does it mean).

And by the way, all new bucklescript projects have namespace enabled by default.

wokalski commented 6 years ago

It's not a limitation of merlin. All merlin features work very well for me under the current setup for nice.re

thangngoc89 commented 6 years ago

@wokalski oh. So what is the problem here then? I'm using VS Code with latest reason-cli@3.0.4

wokalski commented 6 years ago

@thangngoc89 I don't use vscode. That said relaunch it/be careful what directory you launch it from. Folks on #editorsupport will help you out. (but I'm 100% positive there's no such issue with merlin)

thangngoc89 commented 6 years ago

@wokalski I'm heading to it :( . What editor you're using anyway, I'm so tired of VS Code bugs

wokalski commented 6 years ago

I use neovim. VSCode is supposed to have the best integration + the community is working on it actively. I think it's a sane choice if you don't mind it being relatively slow.

thangngoc89 commented 6 years ago

@wokalski VS Code has been my main editor for more than a year. I think the integration for VS Code is not perfect yet. Thank you, I'll stick with it for now

threepointone commented 6 years ago

folks, what should I do here? happy to do it either way. just expected that nice.re would be a unique package name, so importing I thought would be easier.

wokalski commented 6 years ago

I think it's good the way it is.

threepointone commented 6 years ago

cool cool. closing this, we'll revisit after it gets real usage

thangngoc89 commented 6 years ago

@threepointone oh. I forgot. Someone asked on Discord about an error with this package. It's caused because package.json's name and bsbconfig's is mismatch. You can still have Nice namespace those. Just name the package name correctly

threepointone commented 6 years ago

done https://github.com/threepointone/bs-nice/commit/3039f00a591b2392451a5487053cf3dcbe153365