search

threepointone / glamor

inline css for react et al
MIT License
3.66k stars 199 forks source link

Use current version of inline-style-prefixer #396

Open kyptin opened 3 years ago

kyptin commented 3 years ago

This crosses the v5.0.0 version, which required some changes to the import paths. All tests still pass.

It turns out crossing this threshold is important for us, because we depend on libraries that depend on post-5.0.0 versions of inline-style-prefixer, and the two versions are incompatible. Node resolves this by allowing multiple versions of a single package in the same project. But we're running this code in browsers, and we're constrained to using a bundler that doesn't support multiple versions. So if we can bump this library to use a post-5.0.0 version, all uses will be compatible.

threepointone commented 3 years ago

Sorry I haven't been on this project for a while, but this seems like a worthy update. Give me a few days and I'll get this in.

tggreene commented 3 years ago

Awesome, thanks @kyptin this has been on my todo list for ages for the exact same use case as yours (evergreen-ui + shadow-cljs), I ended up using webpack to create a separate lib.js as described here.

I'm hoping this will make using evergreen substantially simpler via clojurescript :tada:.