linting - Githubissues

threepointone / ratpack

ready. set. go!

197 stars 10 forks source link

linting #18

Closed threepointone closed 7 years ago

threepointone commented 7 years ago

multiple issues -

should we have a default eslint config, overridable with pragmas, that is run in a loader? CRA does this with some success
how should this integrate with editors? Ideally I'd like for it to just work, syntax checking and all. bonus if you can do reason checking too.

yatharthx commented 7 years ago

@threepointone I guess having a default eslint config (overridable, as you say) makes sense. We can have a wrapper around of eslint to solve the purpose ( something like XO ). What do you think?

I'm not really sure about the integration with editors. Maybe we can come back to it later.

threepointone commented 7 years ago

don't want to make wrapper, provides no utility beyond what already exists out there.

threepointone commented 7 years ago

some options

letting user manually edit the eslintConfig field in .ratpack/package.json
pragma // @ratpack { lint: { ... } }

threepointone commented 7 years ago

not going to bikeshed on this too much. copied CRA's setup, shows errors in-browser. closing for now.