search

threerings / getdown

Download, Install, Update
Other
507 stars 125 forks source link

digest difference on zip file when migration from Getdown version 1.7 to version 1.8 #275

Open serge-xav opened 8 months ago

serge-xav commented 8 months ago

Hi,

When trying to upgrade my getdown version to v1.8 I have a strange behavior on zip file contained in my app (it's the only zip file that I have) : The digest result differs on the zip file, and only on the zip file, if the digester is run with getdown version 1.7, or with version 1.8 The file is not changed. Do you have any idea why this behavior ? I'm a bit stuck with this issue in my update getdown process.

serge-xav commented 8 months ago

My issue is similar to the comment here : https://github.com/threerings/getdown/pull/206#issuecomment-493199682

bekoenig commented 8 months ago

Hi @serge-xav,

as I mentioned in https://github.com/threerings/getdown/issues/276, the new algorithm is a good way to compute a stable zip digest. So a new zip package with a same content, but different file attributes has the same digest.

But you are right, that this change is incompatible from client side perspective. To be compatible, we have to compute the digest twice (old and new way).

serge-xav commented 8 months ago

Hi @bekoenig , thanks for your reply,

I understand your point of view, and I know that keeping things compatible accross versions can be difficult. We don't know either if most Getdown users are still dealing with version 1.7 or have migrated to 1.8

On my side, I've a workaround for #275 which is to remove .zip file from the getdownized package, when I'll upgrade my application packages to Getdown 1.8

I guess we should keep this Issue Opened, and see if others have same issue.