master: fixed compare of ldap_result return value

threerings / openvpn-auth-ldap

Implements username/password authentication via LDAP for OpenVPN 2.x.

Other

134 stars 63 forks source link

Closed trammell closed 7 years ago

trammell commented 8 years ago

I'm in the process of testing this to address an issue I'm seeing in a production system. It looks right to me, but I'd appreciate more eyes on it.

tatref commented 8 years ago

It seems fine. I believe it's the same as #11

I encountered the same issue, but could not recompile on a recent GCC (see also https://github.com/threerings/openvpn-auth-ldap/issues/51). If you have any tips,it would be great!

apeschel commented 8 years ago

:+1: This PR looks good to me and fixes a crash-causing bug.

diranged commented 8 years ago

Seriously ... this should get merged -- its been open nearly a year!

manuvaldi commented 8 years ago

tatref commented 8 years ago

Unfortunately, I don't think the original authors are still developping this...

On a side note, has any of you managed to get the code to compile on any recent Linux?