search

threestudio-project / threestudio

A unified framework for 3D content generation.
Apache License 2.0
6.32k stars 480 forks source link

debiased_vsd #192

Closed yankeesong closed 1 year ago

yankeesong commented 1 year ago

Adding score debiasing/clipping for VSD

bennyguo commented 1 year ago

LGTM! Thanks @yankeesong !

bennyguo commented 1 year ago

One more thing, could you please add the option to the DOCUMENTATION.md? Thanks!

yankeesong commented 1 year ago

@bennyguo I believe grad.clip is already in DOCUMENTATION.md under Common configurations for guidance (although previously vsd_guidance doesn't support it). In the future maybe one should create a base guidance class for these common features?

bennyguo commented 1 year ago

Oh you're right. Yes maybe we should to that in the future. Thanks again!