threethan / QuestAudioPatcher

Patches android applications to add the neccessary permissions for background audio on the Meta Quest 2
GNU General Public License v3.0
23 stars 1 forks source link

Update link on README to last version of Discord that displays correctly #1

Closed DevanWolf closed 7 months ago

threethan commented 7 months ago

Thanks for the PR! This isn't quite accurate - the version you linked is totally usable, but does still exhibit some layout errors such as missing margins on some elements.

The version I originally linked has no such issues. Is there any particular benefit to using the version you linked aside from it just being newer? It may be best to add both to the readme.

On an unrelated note, have you had a chance to try out the patcher on an actual headset? If so, did you have any issues or difficulties?

DevanWolf commented 7 months ago

Thanks for the PR! This isn't quite accurate - the version you linked is totally usable, but does still exhibit some layout errors such as missing margins on some elements.

Looks fine to me.

On an unrelated note, have you had a chance to try out the patcher on an actual headset? If so, did you have any issues or difficulties?

  • Musicolet - Crashes after 5 seconds due to anti-piracy measure. Try Android Open Source Music Player instead.
threethan commented 7 months ago

Glad it works for you! This version still has a number of visual issues for me. I tried it again, and the chat section was also very narrow. This may be due to window resolution or DPI which might vary between headsets.

I'm also not comfortable linking to a premodified build of Discord, as doing so may violate copyright (though I doubt anyone would actually care), and there's no way to truly guarantee that none of the modifications were harmful.