search

threshold-network / solidity-contracts

38 stars 18 forks source link

Adds `autoIncrease` flag to increase authorizations in `topUp` #155

Closed vzotova closed 10 months ago

vzotova commented 11 months ago

Based on #153 With flag set to true each topUp will increase authorization amount for all authorized app

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6357329563 check.

github-actions[bot] commented 10 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6864859193 check.

vzotova commented 10 months ago

LGTM! Just one comment: Why using the "toggle" approach instead of a setter? It's slightly less ergonomic, in my opinion, but interested to see what was your line of thinking.

not strong opinion: from code perspective - if you call this tx you want to change parameter/toggle, there is no other options that you can change except to opposite value. In the same case setter should fail when parameter is equal.

github-actions[bot] commented 10 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6864949782 check.

github-actions[bot] commented 10 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6928617748 check.

github-actions[bot] commented 10 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6931780997 check.