threshold-network / solidity-contracts

39 stars 18 forks source link

Second step to remove legacy #159

Open vzotova opened 11 months ago

vzotova commented 11 months ago

Now when all legacy token unstaked we don't need any support of it. All methods related to legacy were removed including new one to force unstake.

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7011406420 check.

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7011594546 check.

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7011601971 check.

michalinacienciala commented 11 months ago

Do we still need the @keep-network/keep-core dependency in package.json?

vzotova commented 11 months ago

Do we still need the @keep-network/keep-core dependency in package.json?

Didn't find any usage so removed, @michalinacienciala could you check please that nothing needed was not removed?

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7021124328 check.

github-actions[bot] commented 11 months ago

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7036583518 check.

vzotova commented 7 months ago

Bye bye, legacy staking 👋

Please, lmk when the new version of the contract is deployed since it will require some update on subgraphs.

Just a question: why the struct StakingProviderInfo in TokenStaking.sol is still keeping nuInTStake and keepInTStake?

otherwise data layout will be corrupted and other values would not be get correctly. knowing that those slots are 0 we can theoretically reuse them for something new but I'd avoid it too