threshold-network / token-dashboard

23 stars 24 forks source link

SDK 2.0.0 integration #654

Closed kpyszkowski closed 10 months ago

kpyszkowski commented 10 months ago

Refs: https://github.com/threshold-network/token-dashboard/issues/648

With this pull request the version 2.x.x of @keep-network/tbtc-v2.ts is being integrated into token-dashboard.

The SDK is consumed by the TBTC module of the Threshold class performing as the communication layer with chain-related actions. By the integration it was managed to remove the following dependencies:

The complexity of the code has reduced since a lot of logic is handled by the SDK itself. It came down to calling methods exposed by the SDK.

The mock bitcoin client used for development purpose has been integrated with the latest SDK API. Contracts passed to the SDK's initialization function are now conditionally resolved basing on the chain it runs on. Development variants of testnet artifacts are now stored in the repo since the SDK is contract agnostic and by design contracts cannot be packed into it.

To improve the readability and transparency of parameters passed between callbacks and methods it was made a decision to apply required transformations possibly only on the TBTC module end. It mostly refers to the Hex - string conversions.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.

lukasz-zimnoch commented 10 months ago

Amazing work @kpyszkowski @michalsmiarowski 🤌 Let's merge it!

github-actions[bot] commented 10 months ago

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-2.0.0-integration/index.html.